-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Authlib] Add missing stubs #14368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Authlib] Add missing stubs #14368
Conversation
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
It looks like this PR breaks
Works fine with |
hmm, it's strange if this PR really leads to such consequences. integrations stubs were not "removed" because they didn't exist anyway. they were just added to stuballow file to ignore errors associated with them. if we add them, then errors will occur that stubtests can't import third-party library |
As @donBarbos pointed out, apart from That said, we would of course welcome any additions to our stubs that add (selected) integrations. |
It's |
The thing is that they were never part of type stubs at all. |
Oh, now I see what could be the issue. We've removed the |
% cat t.py
from authlib.integrations.requests_client import OAuth2Session
% mypy t.py
t.py:1: error: Cannot find implementation or library stub for module named "authlib.integrations.requests_client" [import-not-found]
t.py:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 1 source file)
% pip freeze | grep -i authlib
Authlib==1.6.0
types-Authlib==1.6.0.20250708 Downgrading to
|
@pkit Could you confirm that the problem has been fixed with |
*I used
ClassVar
for uppercase attributes because these attributes are often overridden in child classes andFinal
doesn't allow that.