Remove obsolete comments from turtle.pyi #14474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it would be possible to use the hack described in the comment now that pytype support has been removed, that hack is a bit too "magical" for stubs that are supposed to be fairly straight-forward API descriptions. This would also introduce extra stub-only attributes and would imply that e.g. `_Screen.setup()` and `setup()` refer to the same object at runtime when they don't.
Hmm, we already use this technique in Lines 103 to 128 in 981bd8e I think that we probably could have started using a similar technique in |
|
Hmm, I see what you mean about |
AlexWaygood
approved these changes
Jul 27, 2025
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it would be possible to use the hack described in the comment
now that pytype support has been removed, that hack is a bit too
"magical" for stubs that are supposed to be fairly straight-forward
API descriptions. This would also introduce extra stub-only attributes
and would imply that e.g.
_Screen.setup()andsetup()refer to thesame object at runtime when they don't.