Type stub for win32com.server
#14492
Conversation
This comment has been minimized.
This comment has been minimized.
|
|
||
| def RegisterClassFactories( | ||
| clsids: Iterable[PyIID], flags: int | None = None, clsctx: int | None = None | ||
| ) -> list[tuple[PyIClassFactory, Any]]: ... |
There was a problem hiding this comment.
Uses of Any need to be accompanied by a comment explaining why Any is needed / what types are possible at runtime.
There was a problem hiding this comment.
Thank you for your review! I accepted all your comments. :D
For the Any here, I looked up the C code of pywin32 and found that two of them are int. They are now welled annotated. (I also update the pythoncom.pyi to meet the two ints). The third Any is because it has no use. I add a comment explaining that.
| def _set_string(path: str | None, value: str, base: PyHKEY | int = HKEY_CLASSES_ROOT) -> None: ... | ||
| def _get_string(path: str | None, base: PyHKEY | int = HKEY_CLASSES_ROOT) -> str | None: ... | ||
| def _remove_key(path: str | None, base: PyHKEY | int = HKEY_CLASSES_ROOT) -> None: ... | ||
| def recurse_delete_key(path: str | None, base: PyHKEY | int = HKEY_CLASSES_ROOT) -> None: ... |
There was a problem hiding this comment.
| def recurse_delete_key(path: str | None, base: PyHKEY | int = HKEY_CLASSES_ROOT) -> None: ... | |
| def recurse_delete_key(path: str | None, base: PyHKEY | int = -2147483648) -> None: ... |
There was a problem hiding this comment.
Although, I'm wondering, is it really good to replace HKEY_CLASSES_ROOT? This constant seems to be better understood。
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
fix #14440.