Skip to content

Improve accuracy of six byte index methods #9117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 10, 2022
Merged

Improve accuracy of six byte index methods #9117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
45c2402
Improve accuracy of `six` byte index methods
Avasam Nov 6, 2022
a8c330a
Use SupportsGetItem
Avasam Nov 7, 2022
5ac3686
Fix failing stubtest
Avasam Nov 7, 2022
9991a0b
Fix? SupportsGetItem __contains__
Avasam Nov 7, 2022
444b616
Use Any as SupportsGetItem _VT_co
Avasam Nov 7, 2022
6c9f88c
byte2int as method
Avasam Nov 7, 2022
b438335
Added back to allowlist
Avasam Nov 7, 2022
e6d848a
Merge branch 'main' into six-buffer-index
Avasam Nov 7, 2022
f6cd9b4
Merge branch 'main' of https://github.com/python/typeshed into six-bu…
Avasam Nov 8, 2022
70b2067
Updated comments.
Avasam Nov 8, 2022
f7c9c8f
swap getitem overload order
Avasam Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added back to allowlist
  • Loading branch information
@Avasam
Avasam committed Nov 7, 2022
commit b438335993fd925ef95d2eb063e8bb955d094357
9 changes: 7 additions & 2 deletions stdlib/_operator.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,13 @@ class itemgetter(Generic[_T_co]):
# mypy lacks support for PEP 646 https://github.com/python/mypy/issues/12280
@overload
def __new__(cls, *items: _T_co) -> itemgetter[tuple[_T_co, ...]]: ...
# A bug in mypy prevents using _T instead of Any here.
def __call__(self, obj: SupportsGetItem[_T_co, Any]) -> Any: ...
# __key: _KT_contra in SupportsGetItem seems to be causing variance issues, ie:
# TypeVar "_KT_contra@SupportsGetItem" is contravariant
# "tuple[int, int]" is incompatible with protocol "SupportsIndex"
# preventing [_T_co, ...] instead of [Any, ...]
#
# A bug in mypy prevents using [..., _T] instead of [..., Any] here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should link to the bug in the mypy issue tracker.

def __call__(self, obj: SupportsGetItem[Any, Any]) -> Any: ...

@final
class methodcaller:
Expand Down
2 changes: 2 additions & 0 deletions stubs/six/@tests/stubtest_allowlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ six.get_method_self
six.viewitems
six.viewkeys
six.viewvalues
# Should be `operator.itemgetter[int]`. But a bug in mypy prevents using TypeVar in itemgetter__call__
six.byte2int

# Unclear problems
six.callable
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy