Edit error marker comments on some tests #2048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangdanny97
commented
Jul 18, 2025
| @@ -23,8 +23,13 @@ class Color(Enum): | |||
| # > constructor. Instead, the call performs a value-based lookup of an | |||
| # > enum member. | |||
|
|
|||
| assert_type(Color["RED"], Color) # 'Literal[Color.RED]' is also acceptable | |||
There was a problem hiding this comment.
felt odd to assert_type here and say that another type is also acceptable. I tried to put both versions down, so that type checkers have discretion on which one to implement w/o the test failing.
I assume that if a checker emits an error on both lines the test will fail - could the maintainers please confirm this assumption?
There was a problem hiding this comment.
That's right; this is documented in the "Test case syntax" section in conformance/README.
yangdanny97
commented
Jul 18, 2025
| @@ -65,7 +65,7 @@ def method3() -> None: # E[method3] | |||
| pass | |||
|
|
|||
| @overload # E[method4] | |||
| def method4(self, x: int) -> int: | |||
| def method4(self, x: int) -> int: # E[method4] | |||
There was a problem hiding this comment.
Pyrefly emits diagnostics on the line of the def, not the line with the @overload
This is similar to what I did in #1980
JelleZijlstra
approved these changes
Jul 18, 2025
rchen152
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See inline comments for why