feat(types): add __dir__ to RESTObject to expose attributes #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't even know about This change does make sense! Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
__dir__magic method to theRESTObjectclass in order to expose and allow introspection on the attributes that the object might have.This is very useful to me when exploring the API in an interactive console.
Normally I'll call
dir(obj)(orobj?in iPython shell) to try to discover what methods and attributes exist for the object. However, the attributes in the.attributesproperty are not currently exposed, requiring the extra step of checking.attributeson each object I explore this way.Hope this makes sense and that this change, if accepted, will help others.