fix: adds missing status check methods for merge requests #3128
Conversation
af3f374 to
6bd04ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3128 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 98 98
Lines 6057 6067 +10
=======================================
+ Hits 5895 5905 +10
Misses 162 162
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
6bd04ca to
d0abf43
Compare
|
@nejch It doesn't seem like we have a Gitlab API to get a single external status check for a project, only list method is supported. is there a cleaner way this can be approached/implemented? I was actually thinking about raising with Gitlab. |
d0abf43 to
0a66ae5
Compare
0a66ae5 to
6eee494
Compare
5c5a336 to
cd81aea
Compare
cd81aea to
9430f4d
Compare
9430f4d to
b8a42d5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements the missing status check methods for merge requests as promised in issue #3103.
- Adds fixtures and tests for listing and updating merge request external status checks
- Introduces new classes for handling merge request status check responses in the API client
- Updates documentation to reflect the new API and naming conventions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/objects/test_status_checks.py | Added fixtures and tests for external status checks functionality |
| tests/functional/api/test_merge_requests.py | Introduced functional test for setting merge request external status |
| gitlab/v4/objects/status_checks.py | Added new manager and response classes for status check updates |
| gitlab/v4/objects/merge_requests.py | Updated merge request object to include new status check managers |
| docs/gl_objects/status_checks.rst | Revised documentation to reflect new external status check methods |
Comments suppressed due to low confidence (1)
gitlab/v4/objects/status_checks.py:66
- [nitpick] The docstring for the update method in ProjectMergeRequestStatusCheckResponseManager should describe updating a merge request status check response rather than referring to a Label.
"""Update a Label on the server."""
| "sha": merge_request.sha, | ||
| } | ||
| ) | ||
| response["status"] == "passed" |
There was a problem hiding this comment.
The status update check is currently a no-op; use an assertion (e.g., assert response["status"] == "passed") to properly validate the response.
| response["status"] == "passed" | |
| assert response["status"] == "passed" |
Copilot uses AI. Check for mistakes.
|
|
||
| Delete an external status check:: | ||
|
|
||
| status_check.delete(status_check_id) | ||
| external_status_check.delete(externa_status_check_id) |
There was a problem hiding this comment.
There is a typo in the variable name 'externa_status_check_id'; it should be 'external_status_check_id'.
| external_status_check.delete(externa_status_check_id) | |
| external_status_check.delete(external_status_check_id) |
Copilot uses AI. Check for mistakes.
Implements promised changes in #3103