Support None for set_option(OPT_NETWORK_TIMEOUT) #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 67.96% 68.07% +0.11%
==========================================
Files 48 48
Lines 4676 4680 +4
Branches 785 786 +1
==========================================
+ Hits 3178 3186 +8
+ Misses 1146 1144 -2
+ Partials 352 350 -2
Continue to review full report at Codecov.
|
The setter for network timeout and timeout options now support None as value. None is mapped to infinity. Closes: python-ldap#95 Signed-off-by: Christian Heimes <cheimes@redhat.com>
|
Looks great at first glance! |
|
Rewriting the conversion error message should happen only on TypeError. I changed that, (hopefully) made the control flow a bit more straightforward, and removed the nonstandard PyNone_Check. |
tiran
commented
Dec 8, 2017
| } else { | ||
| /* 'd' handles int/long */ | ||
| if (!PyArg_Parse(value, "d:set_option", &doubleval)) { | ||
| if (PyErr_ExceptionMatches(PyExc_TypeError)) { |
There was a problem hiding this comment.
Good catch! I haven't considered overflows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setter for network timeout and timeout options now support None as
value. None is mapped to infinity.
Closes: #95
Signed-off-by: Christian Heimes cheimes@redhat.com