Drop distutils workaround and simplify setup.py #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I like the direction! |
Modern Python installations contain setuptools. It is reasonable to expect it to exist. Simplifies setup.py and removes the large comment explaining the workaround.
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 68.96% 68.87% -0.09%
==========================================
Files 49 49
Lines 4694 4694
Branches 789 789
==========================================
- Hits 3237 3233 -4
- Misses 1108 1111 +3
- Partials 349 350 +1
Continue to review full report at Codecov.
|
|
Looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern Python installations contain setuptools. It is reasonable to expect it to exist. Simplifies
setup.pyand removes the large comment explaining the workaround.