Use correct types for BER en/decode #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ber_scanf() and ber_printf() "i" format uses ber_int_t. lber_types.h
defines the type as int but Python code assumes the type to be unsigned
long:
#define LBER_INT_T int
typedef LBER_INT_T ber_int_t;
The code was working fine on little endian machines but broke on big
endian machines. ber_int_t is now correctly parsed as signed int.
Fixes: python-ldap#161
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 69.6% 69.61% +<.01%
==========================================
Files 49 49
Lines 4731 4732 +1
Branches 817 817
==========================================
+ Hits 3293 3294 +1
Misses 1084 1084
Partials 354 354
Continue to review full report at Codecov.
|
|
This is not a regression from python-ldap 2.5, right? If that's the case, it shouldn't hold back the 3.0 release. |
|
The bad code has been there for a long time, at least 2011. We didn't notice the bug because we just started to test the feature. I can either ship a patch with RPM or we fix it in RC1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ber_scanf() and ber_printf() "i" format uses ber_int_t. lber_types.h
defines the type as int but Python code assumes the type to be unsigned
long:
The code was working fine on little endian machines but broke on big
endian machines. ber_int_t is now correctly parsed as signed int.
Fixes: #161
Signed-off-by: Christian Heimes cheimes@redhat.com