Make bytes mode TypeError more useful #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3659329 to
ce6db91
Compare
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 69.6% 69.61% +<.01%
==========================================
Files 49 49
Lines 4731 4732 +1
Branches 817 817
==========================================
+ Hits 3293 3294 +1
Misses 1084 1084
Partials 354 354
Continue to review full report at Codecov.
|
ce6db91 to
6a43e92
Compare
It's a bit hard to understand where the TypeError excactly comes from. The exception now contains the argument name. Signed-off-by: Christian Heimes <cheimes@redhat.com>
6a43e92 to
1e9c903
Compare
encukou
reviewed
Jan 16, 2018
Lib/ldap/ldapobject.py
Outdated
| raise TypeError( | ||
| "All provided fields *must* be bytes when bytes mode is on; " | ||
| "got {}={!r}".format(arg_name, value) | ||
| ) |
There was a problem hiding this comment.
We did a similar thing with the warnings, but removed the value altogether.
Error messages might end up in logs as well; how would you feel about only mentioning the arg_name?
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit hard to understand where the TypeError excactly comes from.
The exception now contains the argument name.
Signed-off-by: Christian Heimes cheimes@redhat.com