Rewrite cidict and LDAPUrlExtensions in terms of MutableMapping #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
==========================================
+ Coverage 71.46% 71.71% +0.24%
==========================================
Files 49 50 +1
Lines 4714 4748 +34
Branches 785 791 +6
==========================================
+ Hits 3369 3405 +36
+ Misses 1025 1022 -3
- Partials 320 321 +1
Continue to review full report at Codecov.
|
jdufresne
reviewed
Mar 16, 2018
tiran
requested changes
Mar 16, 2018
a57cd7f to
d311973
Compare
|
@tiran, your comments should be addressed now. Could you re-review? |
tiran
previously requested changes
May 28, 2020
|
@encukou Could you please rebase your PR? |
The UserDict API is not specified when it comes to extending: it is not clear which methods can be safely overridden. The MutableMapping ABC fixes this problem by providing an explicit set of abstract methods, in terms of which the rest of the API is implemented. Switch to using MutableMapping for cidict.
The UserDict API is not specified when it comes to extending: it is not clear which methods can be safely overridden. The MutableMapping ABC fixes this problem by providing an explicit set of abstract methods, in terms of which the rest of the API is implemented. Switch to using MutableMapping for LDAPUrlExtensions.
|
Here it is. |
|
LGTM, let's wait for Travis. |
|
The Travis job for b1b3b5a is green: https://travis-ci.org/github/python-ldap/python-ldap/builds/695164011 |
The functions were deprecated rather than removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
he UserDict API is not specified when it comes to extending:
it is not clear which methods can be safely overridden.
The MutableMapping ABC fixes this problem by providing an explicit
set of abstract methods, in terms of which the rest of the API
is implemented.