Skip to content

Disable SASL external when missing SASL support #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2018
Merged

Disable SASL external when missing SASL support #190

merged 1 commit into from
Mar 15, 2018

Conversation

gabrielbriones
Copy link
Contributor

@codecov
Copy link

codecov bot commented Mar 15, 2018 •
edited
Loading

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   70.25%   70.25%           
=======================================
  Files          49       49           
  Lines        4811     4811           
  Branches      810      810           
=======================================
  Hits         3380     3380           
  Misses       1098     1098           
  Partials      333      333
Impacted Files Coverage Δ
Lib/slapdtest/_slapdtest.py 82.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97aa653...65a23f8. Read the comment docs.

@tiran
Copy link
Member

tiran commented Mar 15, 2018

LGTM

Please add Closes: https://github.com/python-ldap/python-ldap/issues/189 to your commit message.

@encukou encukou merged commit fd0ec90 into python-ldap:master Mar 15, 2018
@encukou
Copy link
Member

encukou commented Mar 15, 2018

Thank you for sharing the fix, @gabrielbriones!

Please add Closes: https://github.com/python-ldap/python-ldap/issues/189 to your commit message.

I did that when squashing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielbriones @tiran @encukou
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy