Make SlapdObject.root_dn a property #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure looks unrelated to this change. |
tiran
requested changes
Mar 26, 2018
Lib/slapdtest/_slapdtest.py
Outdated
| @@ -232,6 +231,10 @@ def __init__(self): | |||
| self.clientcert = os.path.join(HERE, 'certs/client.pem') | |||
| self.clientkey = os.path.join(HERE, 'certs/client.key') | |||
|
|
|||
| @property | |||
| def root_dn(self): | |||
| return 'cn=%s,%s' % (self.root_cn, self.suffix) | |||
There was a problem hiding this comment.
Good idea, but please use format:
return 'cn={self.root_cn},{self.suffix}'.format(self=self)
Allows overriding SlapdObject.suffix or SlapdObject.root_cn without also requiring root_dn be defined. It is now computed from the existing values at runtime. The result is an easier to use SlapdObject class.
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
- Coverage 70.25% 68.49% -1.76%
==========================================
Files 49 49
Lines 4811 4803 -8
Branches 810 808 -2
==========================================
- Hits 3380 3290 -90
- Misses 1098 1182 +84
+ Partials 333 331 -2
Continue to review full report at Codecov.
|
|
Thanks for the review. I've made the suggested change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows overriding
SlapdObject.suffixorSlapdObject.root_cnwithout also requiringroot_dnbe defined. It is now computed from the existing values at runtime. The result is an easier to useSlapdObjectclass.