In SlapdObject, build include directives dynamically #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
requested changes
Mar 26, 2018
Lib/slapdtest/_slapdtest.py
Outdated
| @@ -330,6 +331,12 @@ def gen_config(self): | |||
| } | |||
| return self.slapd_conf_template % config_dict | |||
|
|
|||
| def _include_directives(self): | |||
There was a problem hiding this comment.
There is no need for an extra function. Instead of a new function, simply create a variable in the gen_config method and use it as 'include_directives': include_directives,.
Allows overriding openldap_schema_files without requiring rewriting the conf file.
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
- Coverage 70.25% 67.45% -2.81%
==========================================
Files 49 49
Lines 4811 4799 -12
Branches 810 809 -1
==========================================
- Hits 3380 3237 -143
- Misses 1098 1215 +117
- Partials 333 347 +14
Continue to review full report at Codecov.
|
|
Thanks for the review. I've made the suggested change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows overriding openldap_schema_files without requiring rewriting the conf file.