Skip to content

Fix escape dn chars #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2019
Merged

Conversation

spaceone
Copy link
Contributor

  • Fixed escaping a single space ldap.dn.escpae_dn_chars(' ')
  • Adjust the tests to include a test for every escaped character

See Issue #252

@spaceone spaceone force-pushed the fix-escape-dn-chars branch from 7ca25c6 to cf908f1 Compare March 17, 2019 13:14
@codecov
Copy link

codecov bot commented Mar 17, 2019

Codecov Report

Merging #268 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage    71.1%   71.14%   +0.04%     
==========================================
  Files          49       49              
  Lines        4818     4818              
  Branches      812      812              
==========================================
+ Hits         3426     3428       +2     
+ Misses       1056     1055       -1     
+ Partials      336      335       -1
Impacted Files Coverage Δ
Lib/ldap/dn.py 98.07% <100%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf4761...cf908f1. Read the comment docs.

@encukou encukou merged commit 44a593d into python-ldap:master May 24, 2019
@tiran tiran added this to the 3.3 milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy