Fix TypeError in compare_s, test and document error behavior #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass ``(ldap_res,)`` tuple to string formatting instead of ``ldap_res``. This changes fixes ``TypeError: not all arguments converted during string formatting``. Fixes: python-ldap#270 Signed-off-by: Christian Heimes <cheimes@redhat.com>
compare_s() may fail with an exception in case the DN is not found or the user searches for an unspecified attribute. Signed-off-by: Christian Heimes <cheimes@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
======================================
Coverage 71.1% 71.1%
======================================
Files 49 49
Lines 4818 4818
Branches 812 812
======================================
Hits 3426 3426
- Misses 1056 1057 +1
+ Partials 336 335 -1
Continue to review full report at Codecov.
|
encukou
approved these changes
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix string formatting in compare_ext_s
Pass
(ldap_res,)tuple to string formatting instead ofldap_res.This changes fixes
TypeError: not all arguments converted during string formatting.Fixes: #270
Test and document compare_s error cases
compare_s() may fail with an exception in case the DN is not found or the user searches for an unspecified attribute.