Skip to content

Fix thread support check for Python 3 #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2019
Merged

Fix thread support check for Python 3 #290

merged 1 commit into from
May 22, 2019

Conversation

li-dan
Copy link

@li-dan li-dan commented May 21, 2019

Fixes #289.

@codecov
Copy link

codecov bot commented May 21, 2019 •
edited
Loading

Codecov Report

Merging #290 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
- Coverage    71.1%   70.99%   -0.11%     
==========================================
  Files          49       49              
  Lines        4818     4817       -1     
  Branches      812      812              
==========================================
- Hits         3426     3420       -6     
- Misses       1056     1061       +5     
  Partials      336      336
Impacted Files Coverage Δ
Lib/ldap/__init__.py 90.38% <100%> (-9.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf9dc4...95e1d1a. Read the comment docs.

encukou
encukou approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@encukou encukou merged commit 95e1d1a into python-ldap:master May 22, 2019
@li-dan li-dan deleted the issue_289 branch May 22, 2019 13:03
@tiran tiran added this to the 3.3 milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

Thread support check is broken under Python 3
3 participants
@li-dan @encukou @tiran
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy