Skip to content

Doc: Use bytes for attribute values in example #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2020

Conversation

encukou
Copy link
Member

@encukou encukou commented Jan 29, 2020

Fixes: #306

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #317 into master will decrease coverage by 0.68%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #317      +/-   ##
=========================================
- Coverage   70.78%   70.1%   -0.69%     
=========================================
  Files          49      49              
  Lines        4796    4796              
  Branches      804     804              
=========================================
- Hits         3395    3362      -33     
- Misses       1062    1086      +24     
- Partials      339     348       +9
Impacted Files Coverage Δ
Lib/ldap/functions.py 80% <0%> (-17.5%) ⬇️
Lib/ldap/__init__.py 76.92% <0%> (-13.47%) ⬇️
Lib/ldap/ldapobject.py 72.61% <0%> (-3.77%) ⬇️
Lib/ldap/controls/deref.py 57.14% <0%> (ø) ⬆️
Lib/ldap/sasl.py 80.55% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 532ffc0...ff5524a. Read the comment docs.

@encukou
Copy link
Member Author

encukou commented May 6, 2020

No review for 3 months :(
This is not a code change, so I'll merge without review.

@encukou encukou merged commit 9005ba9 into python-ldap:master May 6, 2020
@encukou encukou deleted the gh-306 branch May 6, 2020 12:57
@tiran tiran added this to the 3.3 milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example in documentation does not work
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy