Skip to content

Fix NULL deref and checks in LDAPmessage_to_python #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

tiran
Copy link
Member

@tiran tiran commented Jun 5, 2020

The function LDAPmessage_to_python() had some potential NULL pointer
derefs and missed a couple of errors checks. It's still not perfect but
a bit better now.

Signed-off-by: Christian Heimes cheimes@redhat.com

The function LDAPmessage_to_python() had some potential NULL pointer
derefs and missed a couple of errors checks. It's still not perfect but
a bit better now.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit better it is.

For some reason, Travis CI is not reporting results. But the build for e59905c passed: https://travis-ci.org/github/python-ldap/python-ldap/builds/695145760

@encukou encukou merged commit 72a4707 into python-ldap:master Jun 5, 2020
@tiran tiran added this to the 3.3 milestone Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy