Skip to content

LDAPUrl now treats urlscheme cases insensitive #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2020

Conversation

tiran
Copy link
Member

@tiran tiran commented Jun 6, 2020

Fixes: #280
Signed-off-by: Christian Heimes cheimes@redhat.com
Co-authored-by: David Mulder dmulder@suse.com

@tiran tiran added this to the 3.3 milestone Jun 6, 2020
@codecov
Copy link

codecov bot commented Jun 6, 2020

Codecov Report

Merging #347 (cf23d49) into master (39ea8e5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   71.30%   71.29%   -0.02%     
==========================================
  Files          50       50              
  Lines        4796     4793       -3     
  Branches      802      801       -1     
==========================================
- Hits         3420     3417       -3     
  Misses       1045     1045              
  Partials      331      331              
Impacted Files Coverage Δ
Lib/ldapurl.py 74.40% <100.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605a34b...0034123. Read the comment docs.

@tiran tiran modified the milestones: 3.3, future, 4.0 Jun 8, 2020
Fixes: python-ldap#280
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Co-authored-by: David Mulder <dmulder@suse.com>
droideck
droideck previously approved these changes Nov 3, 2020
Copy link
Contributor

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I've started but I haven't finished the review that day.
The code looks good to me!

The mentioned issue is really minor so feel free to merge it as it is. :)

@encukou encukou merged commit 0ef6175 into python-ldap:master Nov 14, 2020
@encukou
Copy link
Member

encukou commented Nov 14, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ldapurl parsing fails when scheme is uppercase
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy