Don't define search path for includes and libs #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compilers' and linkers' default search paths are fine on modern Linux. The custom search path was wrong on 32bit platforms anyway. When library_dirs is defined, distutils also adds rpath to the shared library. An rpath should not be added by default. I only commented out the configuration stanzes to keep them as example. Closes: python-ldap#30 Signed-off-by: Christian Heimes <cheimes@redhat.com>
<sasl/sasl.h> is the standard include path for sasl.h. ``pkg-config --cflags libsasl2`` agrees with me. Signed-off-by: Christian Heimes <cheimes@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilers' and linkers' default search paths are fine on modern Linux. The
custom search path was wrong on 32bit platforms anyway. When library_dirs is
defined, distutils also adds rpath to the shared library. An rpath
should not be added by default.
I only commented out the configuration stanzes to keep them as example.
Closes: #30
Signed-off-by: Christian Heimes cheimes@redhat.com