Fix several compiler warnings and make warnings fatal errors #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
- Coverage 63.31% 63.25% -0.06%
==========================================
Files 46 46
Lines 4391 4395 +4
Branches 749 749
==========================================
Hits 2780 2780
- Misses 1287 1291 +4
Partials 324 324
Continue to review full report at Codecov.
|
d89f9b7 to
ae985e2
Compare
|
Code changes LGTM, but see #53 for the CFLAGS setting. |
LDAPerror_TypeError() returns (PyObject *)NULL. Some functions don't return a PyObject* so technically it's wrong to return (PyObject *)NULL. Return NULL instead. Signed-off-by: Christian Heimes <cheimes@redhat.com>
ldapcontrol.c was missing include of constants.h that defines LDAPerr() and LDAPerror(). Signed-off-by: Christian Heimes <cheimes@redhat.com>
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Signed-off-by: Christian Heimes <cheimes@redhat.com>
ae985e2 to
5b2d2f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(PyObject *)NULL. Some functions don't return aPyObject*so technically it's wrong to return(PyObject *)NULL. Return NULL instead.