Fix schema urlfetch and add tests #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2017
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 63.23% 65.46% +2.22%
==========================================
Files 46 46
Lines 4396 4396
Branches 749 749
==========================================
+ Hits 2780 2878 +98
+ Misses 1292 1188 -104
- Partials 324 330 +6
Continue to review full report at Codecov.
|
|
@encukou The second commit addresses the issue with urlfetch on Python 2.7. I don't know if it's the right way to resolve the issue. It works for me, though. Please have a look. |
|
I believe that's the right fix. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes cheimes@redhat.com