Fix declaration after statement for C90 #53
Conversation
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
- Coverage 63.25% 63.23% -0.02%
==========================================
Files 46 46
Lines 4395 4396 +1
Branches 749 749
==========================================
Hits 2780 2780
- Misses 1291 1292 +1
Partials 324 324
Continue to review full report at Codecov.
|
|
This only sets CFLAGS for Travis. |
|
I don't want to get in the business of detecting compiler flags in setup.py. It is possible but lots of extra work. Or do you want to include autoconf? The flags may work with clang but may not work with old gcc. I just don't want to risk breaking people. |
|
That's reasonable. |
|
Oh fun, now Travis is failing with more warnings. Please merge #49 first. |
In strict ISO C90 mode and on some platforms (e.g. older MSVC), it is not allowed to declare new variables after a statement. I also find it good practice to declare first. Fixes error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] Signed-off-by: Christian Heimes <cheimes@redhat.com>
In strict ISO C90 mode and on some platforms (e.g. older MSVC), it is
not allowed to declare new variables after a statement. I also find it
good practice to declare first.
Fixes error: ISO C90 forbids mixed declarations and code
[-Werror=declaration-after-statement]
Signed-off-by: Christian Heimes cheimes@redhat.com