Skip to content

Test with Python 3.12 #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2023
Merged

Test with Python 3.12 #537

merged 1 commit into from
Oct 4, 2023
+36 −9

Conversation

tiran
Copy link
Member

@tiran tiran commented Oct 2, 2023

  • Add 3.12 to setup.cfg, tox, and GHA
  • Use Ubuntu 22.04 except for Python 3.6
  • Add weekly cronjob to run CI

@tiran tiran force-pushed the py312 branch 2 times, most recently from 812e5f7 to 2761738 Compare October 2, 2023 16:16
@tiran
Copy link
Member Author

tiran commented Oct 2, 2023

The %f format operator was never supported. It's now raising an error in 3.12

https://docs.python.org/3.12/c-api/unicode.html#c.PyUnicode_FromFormat

@tiran tiran force-pushed the py312 branch 2 times, most recently from 9cef3d6 to 74cf689 Compare October 2, 2023 16:32
@tiran
Test with Python 3.12
0000c9e 
- Add 3.12 to setup.cfg, tox, and GHA
- Use Ubuntu 22.04 except for Python 3.6
- Add weekly cronjob to run CI
- Fixed invalid format `%f` in `PyErr_Format`. It's not supported.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
droideck
droideck approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ack

@tiran
Copy link
Member Author

tiran commented Oct 4, 2023

@droideck Could you please reconfigure CI to require Ubuntu with Python pypy3.9 instead of Ubuntu with Python pypy3? actions/setup-python@v4 requires a minor version for PyPy, too.

@droideck
Copy link
Contributor

droideck commented Oct 4, 2023

@droideck Could you please reconfigure CI to require Ubuntu with Python pypy3.9 instead of Ubuntu with Python pypy3? actions/setup-python@v4 requires a minor version for PyPy, too.

Do you mean to modify your PR and change https://github.com/python-ldap/python-ldap/blob/main/.github/workflows/tox-fedora.yml ?
Because for ci.yml, I already see the change in this PR.

Or is there something in GitHub project settings that only maintainers can access? If so, I wasn't able to find... Any guidance is appreciated. :)

@tiran
Copy link
Member Author

tiran commented Oct 4, 2023

Or is there something in GitHub project settings that only maintainers can access? If so, I wasn't able to find... Any guidance is appreciated. :)

It's a GitHub setting somewhere under branch protection / required status checks. Ubuntu with Python pypy3 is a required test, but the test no longer exists.

@droideck
Copy link
Contributor

droideck commented Oct 4, 2023

Or is there something in GitHub project settings that only maintainers can access? If so, I wasn't able to find... Any guidance is appreciated. :)

It's a GitHub setting somewhere under branch protection / required status checks. Ubuntu with Python pypy3 is a required test, but the test no longer exists.

That was it! Hidden under the branch edit button... Thanks!

@tiran tiran merged commit 2229d83 into python-ldap:main Oct 4, 2023
@tiran tiran deleted the py312 branch October 4, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droideck droideck droideck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiran @droideck
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy