Convert slapdtest to package with data #78
Conversation
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 65.6% 66.43% +0.82%
==========================================
Files 46 48 +2
Lines 4396 4659 +263
Branches 749 784 +35
==========================================
+ Hits 2884 3095 +211
- Misses 1182 1208 +26
- Partials 330 356 +26
Continue to review full report at Codecov.
|
|
This is almost what I did offline over the weekend. Let me merge in my changes & rebase. |
The slapdtest module has been converted to a package to ship the test certs as package data. Closes: python-ldap#76 Signed-off-by: Christian Heimes <cheimes@redhat.com>
Now that we ship the certs as part of the package, make them valid for a longer time. CA validity is one day longer than certs, which are one day longer valid than CRL. Signed-off-by: Christian Heimes <cheimes@redhat.com>
We want this to work on any kind of CI, not just the one we use now.
b36eb88 to
04e6f18
Compare
|
The biggest change is moving code into a submodule – logic in |
|
Any suggestions? Do you want to move |
|
Put all the code in one private submodule, which can be split later. And import public API into the package. (For "public API" I used what we currently need outside slapdtest; it can be expanded later.) See this PR. (Best viewed in a local clone; GitHub's timestamp-based order of the commits is confusing.) |
| __version__ = '3.0.0b1' | ||
|
|
||
| from slapdtest._slapdtest import SlapdObject, SlapdTestCase, SysLogHandler | ||
| from slapdtest._slapdtest import skip_unless_ci, requires_tls |
There was a problem hiding this comment.
+1
The test helpers could be moved into a separate module.
The slapdtest module has been converted to a package to ship the test certs as package data.
Prolong life time of certs.
Closes: #76