Skip to content

Check for LDAP schema and slapd binaries #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2017
Merged

Check for LDAP schema and slapd binaries #8

merged 1 commit into from
Nov 25, 2017

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 24, 2017 •
edited
Loading

Integration tests depend on openldap client and server binaries. Fail
with a human readable message in case a tool or schema is missing.

Signed-off-by: Christian Heimes cheimes@redhat.com

@encukou
Copy link
Member

encukou commented Nov 24, 2017

What's your use case?
I'd want the CI tests to go red if something is misconfigured this badly.

@tiran
Copy link
Member Author

tiran commented Nov 24, 2017

I can change the PR to print a useful error message instead of skipping the tests. At the moment the test suite fails with cryptic error messages when schema or client binaries are missing.

@tiran
Check for LDAP schema and slapd binaries
c3876a0 
Integration tests depend on openldap client and server binaries. Fail
with a human readable message in case a tool or schema is missing.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran force-pushed the test_without_client_server branch from 547c98b to c3876a0 Compare November 24, 2017 19:45
@tiran tiran changed the title Skip integration tests when slapd is missing Check for LDAP schema and slapd binaries Nov 24, 2017
@encukou encukou merged commit 4af1d54 into python-ldap:master Nov 25, 2017
@encukou
Copy link
Member

encukou commented Nov 25, 2017

Thanks!
In the future we might want to make a distinction between skipping tests with unmet dependencies, and skipping based on the test matrix (e.g. bytes_mode on Python 3). But CI should always fail if misconfigured.

@tiran tiran deleted the test_without_client_server branch November 25, 2017 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiran @encukou
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy