Skip to content

Add valgrind target to check for memory leaks #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2017
Merged

Add valgrind target to check for memory leaks #83

merged 2 commits into from
Dec 5, 2017

Conversation

tiran
Copy link
Member

@tiran tiran commented Dec 4, 2017

Signed-off-by: Christian Heimes cheimes@redhat.com

@encukou
Copy link
Member

encukou commented Dec 4, 2017

I'll look at this one after 3.0 beta.

@encukou encukou added the on hold label Dec 4, 2017
@tiran tiran force-pushed the make_valgrind branch 2 times, most recently from 88777e7 to fa8322b Compare December 4, 2017 13:02
@encukou encukou removed the on hold label Dec 4, 2017
@tiran tiran mentioned this pull request Dec 5, 2017
Open
@tiran
Add valgrind target to check for memory leaks
edbb378 
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@encukou
Copy link
Member

encukou commented Dec 5, 2017 •
edited
Loading

The python3 and the suppression file path are Fedora-specific. That's as good a default as any, but it needs to be readily configurable.
I tried fixing this, does that look OK?

@tiran
Copy link
Member Author

tiran commented Dec 5, 2017 •
edited
Loading

Use the makefile force, Luke :)

$(PYTHON_SUPP):
    @echo "Need support file"
    exit 1

.PHONY: valgrind
valgrind: | $(PYTHON_SUPP)

@encukou
Check suppression file in make valgrind; improve make target docs
c85f432 
This should make things easier to use for people with different
configurations.
@codecov
Copy link

codecov bot commented Dec 5, 2017 •
edited
Loading

Codecov Report

Merging #83 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   67.72%   67.64%   -0.09%     
==========================================
  Files          48       48              
  Lines        4676     4676              
  Branches      785      785              
==========================================
- Hits         3167     3163       -4     
- Misses       1151     1154       +3     
- Partials      358      359       +1
Impacted Files Coverage Δ
Lib/slapdtest/_slapdtest.py 80.75% <0%> (-1.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4bcf1d...c85f432. Read the comment docs.

@encukou
Copy link
Member

encukou commented Dec 5, 2017

Ooh, shiny! Glad to be your apprentice :)

@encukou encukou merged commit 084ffe0 into python-ldap:master Dec 5, 2017
@tiran tiran deleted the make_valgrind branch December 11, 2017 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiran @encukou
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy