Skip to content

Modify loclist to separate errors from warnings #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Modify loclist to separate errors from warnings #798

wants to merge 1 commit into from

Conversation

bixycler
Copy link
Contributor

@bixycler bixycler commented Oct 6, 2017

  • Separate errors from warnings (errors are shown above warnings)
  • [g:pymode_lint_cwindow] open loclist only if there is at least one error (not warnings)
  • [g:pymode_lint_cwindow] jump to first error

Changes to be committed:
modified: autoload/pymode/lint.vim
modified: autoload/pymode/tools/loclist.vim
modified: autoload/pymode/tools/signs.vim
modified: pymode/rope.py

Modify loclist
868103a 
- Separate errors from warnings (errors are shown above warnings)
- [g:pymode_lint_cwindow] open loclist only if there is at least one error (not warnings)
- [g:pymode_lint_cwindow] jump to first error

Changes to be committed:
	modified:   autoload/pymode/lint.vim
	modified:   autoload/pymode/tools/loclist.vim
	modified:   autoload/pymode/tools/signs.vim
	modified:   pymode/rope.py
@bixycler bixycler changed the title Modify loclist Modify loclist to separate errors from warnings Nov 15, 2017
@fmv1992 fmv1992 force-pushed the develop branch 4 times, most recently from 3f4fc36 to 60c638d Compare November 22, 2017 02:23
@diraol
Copy link
Contributor

diraol commented Feb 14, 2018

I like a lot the idea of this PR! @bixycler can you rebase it against our develop branch to solve the conflict and see if it passes on tests?

@fmv1992 what do you think about this PR?

@fmv1992
Copy link
Contributor

fmv1992 commented Feb 14, 2018

I thought pymode was already like that in the past (show errors first then warnings).

I think we should open the loclist if it is not empty (that is, even if its only warnings they should be opened). The rationale behind this is that users can already pinpoint-ignore what they don't regard as warnings.

So I bet that one could already achieve this feat with:

Skip errors and warnings                                 *'g:pymode_lint_ignore'*
E.g. ["W", "E2"] (Skip all Warnings and the Errors starting with E2) etc.
>
    let g:pymode_lint_ignore = ["E501", "W",]

(from the docs)

@diraol diraol closed this in d704c98 Feb 15, 2018
@diraol
Copy link
Contributor

diraol commented Feb 15, 2018

I've cherry-picked this PR commit and added another one to ensure that loclist is shown also if there are only warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bixycler @diraol @fmv1992
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy