(not semver) Allow parsing of partial version string #108
Conversation
|
@spack971 Thank you for your PR. While it looks interesting, this feature is not compatible with semver: https://semver.org/#spec-item-2. Please check discussion under issue #70. |
|
@ppkt Fair point. I'll adapt the pull request to define a |
Add the `try_parse` function allowing `semver` to parse partial version string. When only a single digit is given, it is assumed to be the major version: `1` is equivalent to `1.0.0`. When two digits are given, it is assumed to be the major and minor parts of the version string: `1.2` is equivalent to `1.2.0`. Signed-off-by: Jimmy Thrasibule <jimmy@thrasibule.mx>
|
Added a new function named |
|
I will personally name such a function |
|
@scls19fr well that was my goal but I couldn't come with a nice name. I'm open to suggestions. |
|
That issue looks very similar to #210 which I've done lately. We've come to the conclusion that we do not want to support a function which doesn't adhere to the semver specification. That means, we avoid partial parsing of a version string. However, to support our developers, we've think to add some recommendations to our documentation is a good idea. As such, I've written a short section into our documentation (see PR #215: "Dealing with Invalid Versions"). @scls19fr With that background, I think, we can close this issue, right? |
|
Closing it as wontfix. There is already a section in the documentation about dealing with invalid versions. |
Allow
semverto parse partial version string.When only a single digit is given, it is assumed to be the major version:
1is equivalent to1.0.0.When two digits are given, it is assumed to be the major and minor parts of the version string:
1.2is equivalent to1.2.0.