Fix #244: Allow list & str for comparison #245
Merged
+139
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #244 and contains the following changes:
The
VersionInfo.compare
method allows alreadyVersionInfo
, dict, tuple/list and str.comparator
with list and str.test_should_not_allow_to_compare_version_with_string
->test_should_compare_version_string
test_should_compare_version_list
test_should_not_allow_to_compare_invalid_versionstring
pytest.mark.parametrize
fortest_should_compare_version_tuples
usage.rst
to document all possibilitiesCHANGELOG