Skip to content

examples: updated timerbot to work with the latest version of the library #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Mindavi
Copy link

@Mindavi Mindavi commented May 25, 2018

I've updated the timerbot example to work with the latest version of the library.
I was working on a bot the other day and found out the example did not work correctly any more.
This pull request should fix that problem.
Perhaps it's also a good idea to have some automated testing for the examples to ensure they won't get out of date?

@Eldinnie
Copy link
Member

Hi @Mindavi ,

Thanks for you contribution. You couldn't really know this, but what you actually did was reversing an example. We already merged #1100 in preperation for the V11 release, including the examples. Unfortunately this means the examples won't work with v10.1.
You can find working examples for the latest version here:
https://github.com/python-telegram-bot/python-telegram-bot/tree/v10.1.0/examples

Closing this PR because it's actually a rollback. But thanks for noticing and wanting to help.

Pieter

@Eldinnie Eldinnie closed this May 25, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy