-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add PR template #2299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PR template #2299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I nitpicked wording, we should go for past tense in all points imo.
I will go over this later and submit a review for the document itself, maybe add more stuff I can think of.
Co-authored-by: Poolitzer <25934244+Poolitzer@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm otherwise
Co-authored-by: Poolitzer <25934244+Poolitzer@users.noreply.github.com>
Thought this would be a neat way to remind both ourself and the PR-authors of some stuff that's easily forgotten … Could be extended if needed. But maybe there's an even better place for this?