Skip to content

Add PR template #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 16, 2021
Merged

Add PR template #2299

merged 5 commits into from
Jan 16, 2021

Conversation

Bibo-Joshi
Copy link
Member

Thought this would be a neat way to remind both ourself and the PR-authors of some stuff that's easily forgotten … Could be extended if needed. But maybe there's an even better place for this?

@Bibo-Joshi Bibo-Joshi added the ⚙️ documentation affected functionality: documentation label Jan 7, 2021
@Bibo-Joshi Bibo-Joshi requested a review from Poolitzer January 7, 2021 20:19
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I nitpicked wording, we should go for past tense in all points imo.

I will go over this later and submit a review for the document itself, maybe add more stuff I can think of.

Co-authored-by: Poolitzer <25934244+Poolitzer@users.noreply.github.com>
@Bibo-Joshi Bibo-Joshi requested a review from Poolitzer January 10, 2021 10:47
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

Co-authored-by: Poolitzer <25934244+Poolitzer@users.noreply.github.com>
@Bibo-Joshi Bibo-Joshi merged commit 7a3fd83 into master Jan 16, 2021
@Bibo-Joshi Bibo-Joshi deleted the pr-template branch January 16, 2021 12:57
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚙️ documentation affected functionality: documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy