Skip to content

A bit more pathlib #2724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 11, 2021
Merged

A bit more pathlib #2724

merged 5 commits into from
Oct 11, 2021

Conversation

Bibo-Joshi
Copy link
Member

Small follow up for #2646.

  • Makes Dispatcher/UpdaterBuilder.private_key accept filepathes (string / pathlib.Path) in addition to bytes
  • introduces a new typing alias for Union[str, Path]

@Bibo-Joshi Bibo-Joshi added this to the v14 milestone Oct 9, 2021
@Bibo-Joshi Bibo-Joshi changed the base branch from master to v14 October 9, 2021 13:24
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of questions since I'm not familiar with builder pattern. Probably will take 1-2 days to understand all of builder pattern...

@Bibo-Joshi Bibo-Joshi changed the title I bit more pathlib A bit more pathlib Oct 10, 2021
# Conflicts:
#	telegram/_files/file.py
#	telegram/_utils/files.py
#	telegram/ext/_builders.py
#	telegram/ext/_picklepersistence.py
#	telegram/ext/_updater.py
#	telegram/request.py
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Bibo-Joshi Bibo-Joshi merged commit 163d598 into v14 Oct 11, 2021
@Bibo-Joshi Bibo-Joshi deleted the more-pathlib branch October 11, 2021 18:24
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2021
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔌 enhancement pr description: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy