Skip to content

Remove job.job queue #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Remove job.job queue #2740

merged 3 commits into from
Oct 21, 2021

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Oct 20, 2021

Just stumbled on this. JobQueue.put seems to be gone since some 5 years … Anyway, if you have access to a job, then you also have access to either the JobQueue directly or at least a CallbackContext instance, which already contains the job_queue, so IMO there is no need to keep this double reference alive (job_queue contains job, contains job_queue)

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests

Breaking changes:

  • the title

@Bibo-Joshi Bibo-Joshi added the 🛠 breaking change type: breaking label Oct 20, 2021
@Bibo-Joshi Bibo-Joshi added this to the v14 milestone Oct 20, 2021
@Bibo-Joshi Bibo-Joshi requested a review from Poolitzer October 20, 2021 18:54
@Bibo-Joshi Bibo-Joshi added the 📋 pending-review work status: pending-review label Oct 21, 2021
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did miss that one, change looks good.

@Bibo-Joshi Bibo-Joshi merged commit 8f4105d into v14 Oct 21, 2021
@Bibo-Joshi Bibo-Joshi deleted the remove-job.job_queue branch October 21, 2021 11:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠 breaking change type: breaking 📋 pending-review work status: pending-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy