Skip to content

Remove some debug prints. IMHO there is still enough debug printing a… #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

springjools
Copy link
Contributor

…nd if there is too much of it, the relevant parts are harder to find.

…nd if there is too much of it, the relevant parts are harder to find.
@leandrotoledo
Copy link
Member

I agree with removing the DEBUG log from telegram/bot.py message decorator.
About the telegram/ext/jobqueue.py, I'll leave to @jh0ker to provide some input as he did some rework there.

@jh0ker
Copy link
Member

jh0ker commented May 25, 2016

Yes, please take a look at #307
The whole ticking thing has been removed, the job queue now sleeps when there are no jobs due. This should reduce spam by a lot. If you still think it's too much, please leave a comment on that PR

@leandrotoledo
Copy link
Member

Hi @springjools, so please rollback telegram/ext/jobqueue.py and instead a comment, remove lines 108 and 111 from bot.py and this will be good to be merged.

Thank you!

@leandrotoledo leandrotoledo mentioned this pull request May 25, 2016
@leandrotoledo leandrotoledo added this to the 5.0 milestone May 28, 2016
@leandrotoledo
Copy link
Member

Marking as obsolete.

@leandrotoledo leandrotoledo removed the 📋 pending-review work status: pending-review label Jul 9, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2020
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔌 enhancement pr description: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy