Add Internal Helper for Deserializing Subclasses #4358
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a20139 to
dc8604f
Compare
harshil21
reviewed
Jul 9, 2024
|
Fair enough. I'll close and just open a new PR to add the test to menubutton :) |
This was referenced Jul 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4346
TBF, this is more clumsy than I had hoped, but if TG continues with the pattern of subclasses it should still save some duplication.
It's a +0 from my side. If you find the logic hard to follow and think that it makes debugging harder, I'm okay with rejecting.