Convenience Functionality for BusinessOpeningHours #4861

Aweryc · 2025-07-14T10:05:14Z

Convenience Functionality for BusinessOpeningHours
-check if the business is open at a given time
-get the opening hours for a given day

-check if the business is open at a given time -get the opening hours for a given day

Convenience Functionality for BusinessOpeningHours -check if the business is open at a given time -get the opening hours for a given day

Bibo-Joshi

Hey. Thanks for your PR!

I gave it first quick look, but without actually reviewing the new logic. For starters, I focused on a few formalities and setup problems since you're apprantly strugging with this #4194 (comment). I hope that my comments help you.
Please also make sure to check the output of the pre-commit ci run in the "status checks" tab on the PR.

Please let me know if you need additional help with getting the tests running & pre-commit to pass - or when that's done and I should review properly :) Looking forward to it!

pyproject.toml

changes/unreleased/48XX._.toml

src/telegram/__main__.py

src/telegram/_utils/datetime.py

Bibo-Joshi · 2025-07-15T14:55:28Z

src/telegram/_utils/datetime.py

+    try:
+        return zoneinfo.ZoneInfo(tz)
+    except zoneinfo.ZoneInfoNotFoundError as err:
+        raise TelegramError(


Suggested change

raise TelegramError(

raise oneinfo.ZoneInfoNotFoundError(

src/telegram/_utils/datetime.py

Bibo-Joshi · 2025-07-15T14:56:33Z

src/telegram/_utils/enum.py

please revert. This is unrelated to your changes and in fact the pre-commit ci run complains about it

tests/_utils/test_datetime.py

Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>

edit 4861.HEoGVs2mYXWzqMahi6SEhV.toml

Aweryc · 2025-07-17T09:24:26Z

Hello. Im having general problems to understand work flow here in git PR )
Some (requested here) changes are applied successfully. Nice.
Some not. After every commit start kind a pack of git actions, right?
Yes I see trace back of errors in a git actions - but have no idea what it means.
I have strong feelings that is not because my files with my code fails it. May be I am wrong)

Please guide me)

Poolitzer · 2025-07-17T17:12:23Z

Hi I am going to give this a shot.

Some (requested here) changes are applied successfully. Nice.
Some not. After every commit start kind a pack of git actions, right?

I do not quite get the question here, which requested changed did you not apply successfully? Yes the git actions will run on every commit. Doesn't really matter, the important part is that they don't fail on the last one.

Yes I see trace back of errors in a git actions - but have no idea what it means.

The pre commit CI is imo pretty self explanatory, you apparently in the second PR also already fixed some issues there, so I am going to assume you understand that. You can also change the branch in this PR to your new one in your repo.

We can ignore the Bot API test, and fix the chango/security analysis later. The important part to ensure you code is working correctly is the pre commit and the unit test.

If you open any unit test run, and wait for it to load, you should have a huge wall of text. Scroll up to leave the flaky tests behind, until you see tests/test_business_classes.py:715: AssertionError. These are now the unit tests which failed, and they explain you where it failed and why (what it expected, what it got). You need to scroll up further to see them all, but you will get quickly an idea what the output format is. So either you need to fix the tests, or your code. Do that for all the tests, and see where that gets you.

If you have more questions, make sure you read through the contrib guidelines and otherwise ask. Just here, or in our development group.

Aweryc · 2025-07-18T13:11:58Z

On my pc i have this

(python-telegram-bot) PS C:\Users\Aweryc\PycharmProjects\python-telegram-bot> pre-commit run -a
ruff.....................................................................Passed
black....................................................................Passed
flake8...................................................................Passed
pylint...................................................................Passed
mypy-ptb.................................................................Passed
mypy-examples............................................................Passed
pyupgrade................................................................Passed
isort....................................................................Passed

Now go to CI steps)

Convenience functionalty boh

# Conflicts: # changes/unreleased/4861.HEoGVs2mYXWzqMahi6SEhV.toml # src/telegram/_utils/datetime.py

Aweryc · 2025-07-21T11:13:12Z

Hello. I made a changes and now some unit tests are passed for different python versions, some ain't.
It is failing just in one test:

test_send_paid_media: tests._files.test_inputmedia.TestSendMediaGroupWithRequest

What should I do?

Bibo-Joshi

Heyho :) Thanks for the updates and sorry for the late reply. I've gone through your code logic now and left several comments, but haven't reviewed the tests yet. As for the failing tests, I opened #4879. Once that's merged, we'll apply it to your branch as well :)

changes/unreleased/4861.HEoGVs2mYXWzqMahi6SEhV.toml

src/telegram/_business.py

Bibo-Joshi · 2025-07-26T14:58:04Z

src/telegram/_business.py

+        if dt.tzinfo is None:
+            dt_utc = dt
+        else:
+            dt_utc = dt.astimezone(verify_timezone(ZoneInfo(self.time_zone_name)))


Suggested change

if dt.tzinfo is None:

dt_utc = dt

else:

dt_utc = dt.astimezone(verify_timezone(ZoneInfo(self.time_zone_name)))

aware_datetime = datetime.replace(tzinfo=verify_timezone(self.time_zone_name)) if datetime.tzinfo is None else datetime

the name dt_utc is a bit misleading as the involved timezones are probably not UTC :)

Bibo-Joshi · 2025-07-26T15:01:12Z

src/telegram/_utils/datetime.py

+def verify_timezone(
+    tz: Union[dtm.tzinfo, zoneinfo.ZoneInfo],
+) -> Optional[Union[zoneinfo.ZoneInfo, dtm.tzinfo]]:
+    """
+    Verifies that the given timezone is a valid timezone.
+    """


Suggested change

def verify_timezone(

tz: Union[dtm.tzinfo, zoneinfo.ZoneInfo],

) -> Optional[Union[zoneinfo.ZoneInfo, dtm.tzinfo]]:

"""

Verifies that the given timezone is a valid timezone.

"""

def get_zoneinfo(

tz: str,

) -> zoneinfo.ZoneInfo:

"""Wrapper around the `ZoneInfo` constructor with slightly more helpful error messages

"""

The goal of this helper is to improve the error message that's raised by ZoneInfo(some_timezone_name) if the tzdata package is not available and the timezone can not be provided by the system. validating that an object is indeed a ZoneInfo object doesn't give any advantage to us :)

Change a doc is ok a got it.
And you want to change type hints and returning value?

Bibo-Joshi · 2025-07-26T15:01:20Z

src/telegram/_utils/datetime.py

+    if isinstance(tz, (dtm.tzinfo, zoneinfo.ZoneInfo)):
+        return tz


Suggested change

if isinstance(tz, (dtm.tzinfo, zoneinfo.ZoneInfo)):

return tz

You suggest just delete this two lines?

Bibo-Joshi · 2025-07-26T15:04:46Z

src/telegram/_utils/datetime.py

+    except (TypeError, ValueError) as e:
+        raise zoneinfo.ZoneInfoNotFoundError(
+            f"No time zone found with key {tz}. "
+            f"Make sure to use a valid time zone name and "
+            f"correct install tzdata (https://pypi.org/project/tzdata/)"
+        ) from e


Suggested change

except (TypeError, ValueError) as e:

raise zoneinfo.ZoneInfoNotFoundError(

f"No time zone found with key {tz}. "

f"Make sure to use a valid time zone name and "

f"correct install tzdata (https://pypi.org/project/tzdata/)"

) from e

from the python docs:

key must be in the form of a relative, normalized POSIX path, with no up-level references. The constructor will raise ValueError if a non-conforming key is passed.

This means that in case the user passes something that is not a timezone name, python will complain. A ValueError does however not really mean that no timezone could be found. Also the error message is already helpful in this case:

ValueError: ZoneInfo keys may not be absolute paths, got: :://urope/Berliuidtaerndiutanrn

got: :://urope/Berliuidtaerndiutanrn

Sorry, cant read this) Is this example of wrong user input?

Bibo-Joshi · 2025-07-26T15:24:06Z

PS: #4879 is merged. You can merge the master branch into yours :)

Aweryc and others added 3 commits July 14, 2025 13:00

Convenience Functionality for BusinessOpeningHours

b175dab

-check if the business is open at a given time -get the opening hours for a given day

Merge pull request #1 from Aweryc/convenience-functionalty-BOH

49aa14b

Convenience Functionality for BusinessOpeningHours -check if the business is open at a given time -get the opening hours for a given day

Merge branch 'master' into master

0cd3963

Bibo-Joshi linked an issue Jul 15, 2025 that may be closed by this pull request

Convenience Functionalty for BusinessOpeningHours #4194

Open

Bibo-Joshi requested changes Jul 15, 2025

View reviewed changes

Aweryc and others added 12 commits July 15, 2025 23:56

Update changes/unreleased/48XX._.toml

e3132e9

Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>

Update src/telegram/_utils/datetime.py

fa4e6cd

Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>

Update src/telegram/_utils/datetime.py

9c183e7

Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>

Update tests/_utils/test_datetime.py

0b836cf

Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>

Rename 48XX._.toml to 4861.HEoGVs2mYXWzqMahi6SEhV.toml

5a91e66

Merge branch 'python-telegram-bot:master' into master

869748e

Update pyproject.toml

83cb615

Revert enum.py

73def0a

Proper re-raise zoneinfo.ZoneInfoNotFoundError

0a70348

Update datetime.py

99634d0

Rename change file .toml

86540bf

revert pyproject.toml

6ff094d

edit 4861.HEoGVs2mYXWzqMahi6SEhV.toml

Bibo-Joshi mentioned this pull request Jul 17, 2025

Convenience functionalty boh #4865

Closed

Aweryc and others added 8 commits July 18, 2025 16:19

remove TelegramError

c63f1eb

Fix a code and tests

a40a573

Merge branch 'master' into convenience-functionalty-BOH

80ebca4

Merge pull request #2 from Aweryc/convenience-functionalty-BOH

264f6f5

Convenience functionalty boh

Merge branch 'python-telegram-bot:master' into master

6bbc7d6

Fix a code and tests

0732859

Merge branch 'convenience-functionalty-BOH'

4c8995e

# Conflicts: # changes/unreleased/4861.HEoGVs2mYXWzqMahi6SEhV.toml # src/telegram/_utils/datetime.py

Merge remote-tracking branch 'origin/master'

74e9d13

# Conflicts: # changes/unreleased/4861.HEoGVs2mYXWzqMahi6SEhV.toml # src/telegram/_utils/datetime.py

Aweryc requested a review from Bibo-Joshi July 21, 2025 11:13

Bibo-Joshi requested changes Jul 26, 2025

View reviewed changes

		if isinstance(tz, (dtm.tzinfo, zoneinfo.ZoneInfo)):
		return tz

Convenience Functionality for BusinessOpeningHours #4861

Are you sure you want to change the base?

Convenience Functionality for BusinessOpeningHours #4861

Uh oh!

Conversation

Aweryc commented Jul 14, 2025

Uh oh!

Bibo-Joshi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Aweryc commented Jul 17, 2025

Uh oh!

Poolitzer commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aweryc commented Jul 18, 2025

Uh oh!

Aweryc commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bibo-Joshi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Bibo-Joshi commented Jul 26, 2025

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Poolitzer commented Jul 17, 2025 •

edited

Loading

Aweryc commented Jul 21, 2025 •

edited

Loading