Skip to content

Move a lot of files #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 22, 2017
Merged

Move a lot of files #674

merged 4 commits into from
Jun 22, 2017

Conversation

jsmnbom
Copy link
Member

@jsmnbom jsmnbom commented Jun 18, 2017

Moves a lot of files into seperate packages so it's easier to maintain.
I have a few questions:

  • Should files be renamed to media?
  • Should we give the tests directory the same treatment?
  • Should all the subpackages have a proper __init__.py file with __all__ despite not being meant for import by the user?
  • Should the subpackages have an underscore prepended since they are internal?

Closes #619

tsnoam
tsnoam requested changes Jun 20, 2017
View reviewed changes
Copy link
Member

@tsnoam tsnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.
Just make sure to merge with latest master and that Travis will pass.

@Eldinnie
Copy link
Member

Eldinnie commented Jun 22, 2017 •
edited
Loading

I would love it if the imports would be grouped (all games imports together) and in alphabetical order too. It's not necessary, but it's looks a lot cleaner
edit - not possible due to dependencies.

@tsnoam tsnoam merged commit 56949bc into master Jun 22, 2017
@tsnoam tsnoam deleted the restructure-internal branch June 22, 2017 18:26
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tsnoam tsnoam tsnoam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split internal code for better maintainability
3 participants
@jsmnbom @Eldinnie @tsnoam
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy