Cache pip for travis and appveyor + update to travis trusty container #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating wheels package since caching was introduced in v7 and I'm not sure what version is default on travis.
Currently about 1min of build time is spent updating libssl... maybe it's newer on trusty?
See travis-ci/travis-ci#6727 for more info too
Eldinnie
reviewed
Jun 22, 2017
| @@ -15,12 +15,14 @@ environment: | |||
| install: | |||
| # We need wheel installed to build wheels | |||
| - "git submodule update --init --recursive" | |||
| - "%PYTHON%\\python.exe -m pip install wheel" | |||
| - "%PYTHON%\\python.exe -m pip install -U wheel" | |||
There was a problem hiding this comment.
Why did you do this? On Appveyor wheel is not installed by default.
There was a problem hiding this comment.
At all? Oh :/
I just wanted to be sure we had a recent enough (can't remember the exact version) so that pip knows how to use it for caching.
inspect.signature() seems to return a string instead of an actual signature on pypy
tsnoam
approved these changes
Jun 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating wheels package since caching was introduced in v7 and I'm not sure what version is default on travis.
Also update to trusty container for (hopefully) a speedup due to not having to update libssl on every single build.