log error trace if there is no error handler registered #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgfilim1
reviewed
Jun 30, 2017
telegram/ext/dispatcher.py
Outdated
| raise error | ||
|
|
||
| except: | ||
| self.logger.exception('No error handlers are registered, logging exception...') |
There was a problem hiding this comment.
Maybe it'll be better to use self.logger.exception('...', exc_info=error) instead of this try-except clause?
jsmnbom
approved these changes
Aug 12, 2017
|
Could you maybe merge from master so tests are updated (so we can get the build to not fail) |
|
merged from master |
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
==========================================
+ Coverage 91.73% 91.74% +<.01%
==========================================
Files 101 101
Lines 4055 4057 +2
Branches 620 621 +1
==========================================
+ Hits 3720 3722 +2
Misses 197 197
Partials 138 138
Continue to review full report at Codecov.
|
This was referenced Dec 8, 2017
This was referenced Mar 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.