python-telegram-bot · tsnoam · Aug 11, 2017 · Jul 29, 2017 · Jul 29, 2017 · Jul 29, 2017
diff --git a/.coveragerc b/.coveragerc
diff --git a/.github/CONTRIBUTING.rst b/.github/CONTRIBUTING.rst
@@ -1,10 +1,10 @@
 How To Contribute
-===================
+=================
 
 Every open source project lives from the generous help by contributors that sacrifice their time and ``python-telegram-bot`` is no different. To make participation as pleasant as possible, this project adheres to the `Code of Conduct`_ by the Python Software Foundation.
 
 Setting things up
--------------------
+-----------------
 
 1. Fork the ``python-telegram-bot`` repository to your GitHub account.
 
@@ -35,7 +35,7 @@ Setting things up
       $ pre-commit install
 
 Finding something to do
-###################
+#######################
 
 If you already know what you'd like to work on, you can skip this section.
 
@@ -44,7 +44,7 @@ If you have an idea for something to do, first check if it's already been filed
 Another great way to start contributing is by writing tests. Tests are really important because they help prevent developers from accidentally breaking existing code, allowing them to build cool things faster. If you're interested in helping out, let the development team know by posting to the `developers' mailing list`_, and we'll help you get started.
 
 Instructions for making a code change
-####################
+#####################################
 
 The central development branch is ``master``, which should be clean and ready for release at any time. In general, all changes should be done as feature branches based off of ``master``.
 
@@ -89,7 +89,7 @@ Here's how to make a one-off code change.
 
      .. code-block::
 
-        $ nosetests -v
+        $ pytest -v
 
    - To actually make the commit (this will trigger tests for yapf, lint and pep8 automatically):
 
@@ -129,19 +129,19 @@ Here's how to make a one-off code change.
 
      .. code-block:: bash
 
-      	$ git checkout your-branch-name
-      	$ git fetch upstream
-	$ git merge upstream/master
-      	$ ...[fix the conflicts]...
-      	$ ...[make sure the tests pass before committing]...
-      	$ git commit -a
-      	$ git push origin your-branch-name
+        $ git checkout your-branch-name
+        $ git fetch upstream
+        $ git merge upstream/master
+        $ ...[fix the conflicts]...
+        $ ...[make sure the tests pass before committing]...
+        $ git commit -a
+        $ git push origin your-branch-name
 
    - If after merging you see local modified files in ``telegram/vendor/`` directory, that you didn't actually touch, that means you need to update submodules with this command:
 
      .. code-block:: bash
 
-      	$ git submodule update --init --recursive
+        $ git submodule update --init --recursive
 
    - At the end, the reviewer will merge the pull request.
 
@@ -155,20 +155,29 @@ Here's how to make a one-off code change.
 7. **Celebrate.** Congratulations, you have contributed to ``python-telegram-bot``!
 
 Style commandments
----------------------
+------------------
 
 Specific commandments
 #####################
 
 - Avoid using "double quotes" where you can reasonably use 'single quotes'.
 
-AssertEqual argument order
-######################
+Assert comparison order
+#######################
 
-- assertEqual method's arguments should be in ('actual', 'expected') order.
+- assert statements should compare in **actual** == **expected** order.
+For example (assuming ``test_call`` is the thing being tested):
+
+.. code-block:: python
+
+    # GOOD
+    assert test_call() == 5
+
+    # BAD
+    assert 5 == test_call()
 
 Properly calling callables
-#######################
+##########################
 
 Methods, functions and classes can specify optional parameters (with default
 values) using Python's keyword arg syntax. When providing a value to such a
@@ -186,7 +195,7 @@ This gives us the flexibility to re-order arguments and more importantly
 to add new required arguments. It's also more explicit and easier to read.
 
 Properly defining optional arguments
-########################
+####################################
 
 It's always good to not initialize optional arguments at class creation,
 instead use ``**kwargs`` to get them. It's well known Telegram API can

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -17,4 +17,4 @@
         files: ^telegram/.*\.py$
         args:
         - --errors-only
-        - --disable=no-name-in-module,import-error
+        - --disable=import-error
diff --git a/.travis.yml b/.travis.yml
@@ -18,18 +18,20 @@ branches:
 cache:
   directories:
     - $HOME/.cache/pip
+    - $HOME/.pre-commit
 before_cache:
   - rm -f $HOME/.cache/pip/log/debug.log
+  - rm -f $HOME/.pre-commit/pre-commit.log
 
 install:
-  - pip install coveralls
+  - pip install coveralls pytest-cov
   - pip install -U wheel
-  - pip install -r requirements.txt
-  - pip install -r requirements-dev.txt
+  - pip install -U -r requirements.txt
+  - pip install -U -r requirements-dev.txt
   - if [[ $TRAVIS_PYTHON_VERSION != 'pypy'* ]]; then pip install ujson; fi
 
 script:
-  - python travis.py
+  - pytest -v --cov=telegram
 
 after_success:
   coveralls
diff --git a/Makefile b/Makefile
@@ -2,7 +2,7 @@
 .PHONY: clean pep257 pep8 yapf lint test install
 
 PYLINT          := pylint
-NOSETESTS       := nosetests
+PYTEST          := pytest
 PEP257          := pep257
 PEP8            := flake8
 YAPF            := yapf
@@ -29,7 +29,7 @@ lint:
 	$(PYLINT) -E telegram --disable=no-name-in-module,import-error
 
 test:
-	$(NOSETESTS) -v
+	$(PYTEST) -v
 
 install:
 	$(PIP)  install -r requirements.txt -r requirements-dev.txt
@@ -41,11 +41,11 @@ help:
 	@echo "- pep8        Check style with flake8"
 	@echo "- lint        Check style with pylint"
 	@echo "- yapf        Check style with yapf"
-	@echo "- test        Run tests"
+	@echo "- test        Run tests using pytest"
 	@echo
 	@echo "Available variables:"
 	@echo "- PYLINT      default: $(PYLINT)"
-	@echo "- NOSETESTS   default: $(NOSETESTS)"
+	@echo "- PYTEST      default: $(PYTEST)"
 	@echo "- PEP257      default: $(PEP257)"
 	@echo "- PEP8        default: $(PEP8)"
 	@echo "- YAPF        default: $(YAPF)"

diff --git a/appveyor.yml b/appveyor.yml
@@ -24,8 +24,4 @@ build: off
 cache: C:\Users\appveyor\pip\wheels
 
 test_script:
-  - "%python%\\Scripts\\nosetests -v --with-flaky --no-flaky-report tests"
-
-after_test:
-  # This step builds your wheels.
-  - "%PYTHON%\\python.exe setup.py bdist_wheel"
+  - "%python%\\Scripts\\pytest -v --cov=telegram"
diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -1,10 +1,9 @@
 flake8
-nose
 pep257
 pylint
 flaky
 yapf
 pre-commit
-pre-commit-hooks
 beautifulsoup4
-rednose
+pytest
+pytest-timeout
diff --git a/setup.cfg b/setup.cfg
@@ -17,3 +17,19 @@ ignore = W503
 based_on_style = google
 split_before_logical_operator = True
 column_limit = 99
+
+[tool:pytest]
+testpaths = tests
+addopts = --no-success-flaky-report -rsxX
+filterwarnings =
+    error
+    ignore::DeprecationWarning
+
+[coverage:run]
+branch = False
+source = telegram
+omit =
+    tests/
+    telegram/__main__.py
+    telegram/vendor/*
+
diff --git a/telegram/bot.py b/telegram/bot.py
@@ -1651,7 +1651,7 @@ def set_webhook(self,
         url_ = '{0}/setWebhook'.format(self.base_url)
 
         # Backwards-compatibility: 'url' used to be named 'webhook_url'
-        if 'webhook_url' in kwargs:
+        if 'webhook_url' in kwargs:  # pragma: no cover
             warnings.warn("The 'webhook_url' parameter has been renamed to 'url' in accordance "
                           "with the API")
 

diff --git a/telegram/callbackquery.py b/telegram/callbackquery.py
@@ -90,7 +90,7 @@ def __init__(self,
 
         self.bot = bot
 
-        self._id_attrs = ('id',)
+        self._id_attrs = (self.id,)
 
     @classmethod
     def de_json(cls, data, bot):

diff --git a/telegram/ext/dispatcher.py b/telegram/ext/dispatcher.py
@@ -135,12 +135,6 @@ def __init__(self, bot, update_queue, workers=4, exception_event=None, job_queue
             else:
                 self._set_singleton(None)
 
-    @classmethod
-    def _reset_singleton(cls):
-        # NOTE: This method was added mainly for test_updater benefit and specifically pypy. Never
-        #       call it in production code.
-        cls.__singleton_semaphore.release()
-
     def _init_async_threads(self, base_name, workers):
         base_name = '{}_'.format(base_name) if base_name else ''
 

diff --git a/telegram/games/game.py b/telegram/games/game.py
@@ -68,7 +68,7 @@ def __init__(self,
         self.description = description
         self.photo = photo
         self.text = text
-        self.text_entities = text_entities
+        self.text_entities = text_entities or list()
         self.animation = animation
 
     @classmethod

diff --git a/telegram/message.py b/telegram/message.py
@@ -232,7 +232,7 @@ def __init__(self,
         self.audio = audio
         self.game = game
         self.document = document
-        self.photo = photo
+        self.photo = photo or list()
         self.sticker = sticker
         self.video = video
         self.voice = voice
@@ -242,10 +242,10 @@ def __init__(self,
         self.location = location
         self.venue = venue
         self._new_chat_member = new_chat_member
-        self.new_chat_members = new_chat_members
+        self.new_chat_members = new_chat_members or list()
         self.left_chat_member = left_chat_member
         self.new_chat_title = new_chat_title
-        self.new_chat_photo = new_chat_photo
+        self.new_chat_photo = new_chat_photo or list()
         self.delete_chat_photo = bool(delete_chat_photo)
         self.group_chat_created = bool(group_chat_created)
         self.supergroup_chat_created = bool(supergroup_chat_created)
@@ -330,7 +330,7 @@ def effective_attachment(self):
         for i in (self.audio, self.game, self.document, self.photo, self.sticker,
                   self.video, self.voice, self.video_note, self.contact, self.location,
                   self.venue, self.invoice, self.successful_payment):
-            if i is not None:
+            if i:
                 self._effective_attachment = i
                 break
         else:

diff --git a/telegram/update.py b/telegram/update.py
@@ -139,7 +139,8 @@ def effective_chat(self):
         """
         :class:`telegram.Chat`: The chat that this update was sent in, no matter what kind of
             update this is. Will be ``None`` for :attr:`inline_query`,
-            :attr:`chosen_inline_result`, :attr:`shipping_query` and :attr:`pre_checkout_query`.
+            :attr:`chosen_inline_result`, :attr:`callback_query` from inline messages,
+            :attr:`shipping_query` and :attr:`pre_checkout_query`.
         """
 
         if self._effective_chat:

diff --git a/telegram/utils/request.py b/telegram/utils/request.py
@@ -34,7 +34,7 @@
     import telegram.vendor.ptb_urllib3.urllib3.contrib.appengine as appengine
     from telegram.vendor.ptb_urllib3.urllib3.connection import HTTPConnection
     from telegram.vendor.ptb_urllib3.urllib3.util.timeout import Timeout
-except ImportError:
+except ImportError:  # pragma: no cover
     warnings.warn("python-telegram-bot wasn't properly installed. Please refer to README.rst on "
                   "how to properly install.")
     raise

diff --git a/tests/README.md b/tests/README.md