Skip to content

Fix sticker tests #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2017
Merged

Fix sticker tests #807

merged 3 commits into from
Sep 1, 2017

Conversation

Eldinnie
Copy link
Member

Added flaky, timeout and xfails to the stickerset bot method tests.

Added flaky, timeout and xfails to the stickerset bot method tests.
@tsnoam
Copy link
Member

tsnoam commented Aug 23, 2017

@Eldinnie Did we contact telegram support about this? Especially on the delete

@Eldinnie
Copy link
Member Author

Only tests failing are the test_official (which should be solved when #806 ) is merged

@Eldinnie Eldinnie mentioned this pull request Aug 23, 2017
@jsmnbom
Copy link
Member

jsmnbom commented Aug 24, 2017

Looks good to me :)
My only question is if we should really be raising an exception when the set is too large? Won't this fail the test_bot_methods_3 too? (and stickers will never be deleted)

@Eldinnie
Copy link
Member Author

@bomjacob It will fail all sticker set tests. But it's in indicator we need to take action (I can add a comment in the code)

@Eldinnie Eldinnie merged commit e13cd58 into master Sep 1, 2017
@Eldinnie Eldinnie deleted the Eldinnie-patch-1 branch September 1, 2017 06:47
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy