Decode Emoji byte strings into unicode strings if using Python 3 #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, I just realized I messed up programming languages in the docstrings of telegram/emoji.py. It says 'Class' instead of 'type'. Maybe you could fix it, so I don't have to create another pull request :) |
This was referenced Oct 23, 2015
Merged
|
My #24 fix was wrong: the emojis should always be strings, not byte arrays... ,maybe we should dig deeper on py2 and py3 unicode compatibility, many bugs come from these things.. |
leandrotoledo
added a commit
that referenced
this pull request
Nov 10, 2015
Decode Emoji byte strings into unicode strings if using Python 3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used a class decorator to call a function upon class creation, that decodes every class attribute of the type 'bytes' into 'str' if sys.version_info.major == 3
Fix for #80