Skip to content

Don't crash on single chracter messages #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2017
Merged

Don't crash on single chracter messages #873

merged 3 commits into from
Oct 15, 2017

Conversation

jsmnbom
Copy link
Member

@jsmnbom jsmnbom commented Oct 15, 2017

Fixes #871

@codecov
Copy link

codecov bot commented Oct 15, 2017

Codecov Report

Merging #873 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #873     +/-   ##
=========================================
- Coverage   91.86%   91.76%   -0.1%     
=========================================
  Files         101      101             
  Lines        4055     4055             
  Branches      620      620             
=========================================
- Hits         3725     3721      -4     
- Misses        194      196      +2     
- Partials      136      138      +2
Flag Coverage Δ
#Appveyor 86.9% <100%> (ø) ⬆️
#Travis 91.31% <100%> (-0.13%) ⬇️
Impacted Files Coverage Δ
telegram/ext/commandhandler.py 88.88% <100%> (ø) ⬆️
telegram/version.py 100% <100%> (ø) ⬆️
telegram/message.py 96.22% <0%> (-0.76%) ⬇️
telegram/bot.py 87.22% <0%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2377438...d70a1e8. Read the comment docs.

@jeffffc
Copy link
Contributor

jeffffc commented Oct 15, 2017

would this still crash when a single / character is received?

@Eldinnie Eldinnie merged commit 8df35fd into master Oct 15, 2017
@Eldinnie Eldinnie deleted the 871-hotfix branch October 15, 2017 14:59
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

commandhandler error after updated the library to the 8.1.0
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy