Skip to content

Store bot in PreCheckoutQuery. #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2017
Merged

Store bot in PreCheckoutQuery. #953

merged 2 commits into from
Dec 30, 2017

Conversation

nmlorg
Copy link
Contributor

@nmlorg nmlorg commented Dec 29, 2017

Fixes #937

@codecov
Copy link

codecov bot commented Dec 29, 2017 •
edited
Loading

Codecov Report

Merging #953 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #953      +/-   ##
==========================================
- Coverage    91.8%   91.68%   -0.13%     
==========================================
  Files         103      103              
  Lines        4040     4040              
  Branches      638      638              
==========================================
- Hits         3709     3704       -5     
- Misses        193      197       +4     
- Partials      138      139       +1
Impacted Files Coverage Δ
telegram/payment/precheckoutquery.py 100% <100%> (ø) ⬆️
telegram/utils/request.py 66.96% <0%> (-0.9%) ⬇️
telegram/bot.py 87.51% <0%> (-0.5%) ⬇️

jsmnbom
jsmnbom approved these changes Dec 29, 2017
View reviewed changes
Copy link
Member

@jsmnbom jsmnbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for fixing this.
Go ahead and add yourself to the Authors.rst list if you'd like ^^

@nmlorg
Copy link
Contributor Author

nmlorg commented Dec 29, 2017

Done
:)

@jsmnbom jsmnbom added the 📋 pending-merge work status: pending-merge label Dec 30, 2017
@tsnoam
Copy link
Member

tsnoam commented Dec 30, 2017

@nmlorg thank you for your contribution.

@tsnoam tsnoam merged commit 5c8470e into python-telegram-bot:master Dec 30, 2017
@nmlorg nmlorg deleted the pcq-set-bot branch December 30, 2017 18:36
This was referenced Mar 2, 2018
Closed
Closed
Merged
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Eldinnie Eldinnie Eldinnie approved these changes

@jsmnbom jsmnbom jsmnbom approved these changes

Assignees
No one assigned
Labels
📋 pending-merge work status: pending-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pre_checkout_query does not store bot.
4 participants
@nmlorg @tsnoam @Eldinnie @jsmnbom
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy