pythoninthegrass · pull · Aug 5, 2025 · Aug 5, 2025 · Aug 5, 2025 · Aug 5, 2025
diff --git a/local-requirements.txt b/local-requirements.txt
@@ -2,7 +2,7 @@ autobahn==23.1.2
 black==25.1.0
 build==1.2.2.post1
 flake8==7.2.0
-mypy==1.17.0
+mypy==1.17.1
 objgraph==3.6.2
 Pillow==11.2.1
 pixelmatch==0.3.0

diff --git a/tests/async/test_defaultbrowsercontext.py b/tests/async/test_defaultbrowsercontext.py
@@ -111,7 +111,7 @@ async def test_context_add_cookies_should_work(
         ]
     )
     assert await page.evaluate("() => document.cookie") == "username=John Doe"
-    assert await page.context.cookies() == [
+    assert _filter_cookies(await page.context.cookies()) == [
         {
             "name": "username",
             "value": "John Doe",
@@ -127,7 +127,7 @@ async def test_context_add_cookies_should_work(
 
 def _filter_cookies(cookies: Sequence[Cookie]) -> List[Cookie]:
     return list(
-        filter(lambda cookie: cookie["domain"] != "copilot.microsoft.com", cookies)
+        filter(lambda cookie: not cookie["domain"].endswith("microsoft.com"), cookies)
     )
 
 

diff --git a/tests/sync/test_browsercontext_events.py b/tests/sync/test_browsercontext_events.py
@@ -172,23 +172,25 @@ def test_dialog_event_should_work_with_inline_script_tag(
 ) -> None:
     def handle_route(request: TestServerRequest) -> None:
         request.setHeader("content-type", "text/html")
-        request.write(b"""<script>window.result = prompt('hey?')</script>""")
+        request.write(b"<script>window.result = prompt('hey?')</script>")
         request.finish()
 
     server.set_route("/popup.html", handle_route)
     page.goto(server.EMPTY_PAGE)
     page.set_content("<a href='popup.html' target=_blank>Click me</a>")
 
-    def handle_dialog(dialog: Dialog) -> None:
-        assert dialog.message == "hey?"
-        assert dialog.page == popup
-        dialog.accept("hello")
+    with (
+        page.context.expect_event("dialog") as dialog_info,
+        page.expect_popup() as popup_info,
+    ):
+        page.click("a")
 
-    page.context.on("dialog", handle_dialog)
+    dialog: Dialog = dialog_info.value
+    popup: Page = popup_info.value
 
-    with page.expect_popup() as popup_info:
-        page.click("a")
-    popup = popup_info.value
+    assert dialog.message == "hey?"
+    assert dialog.page == popup
+    dialog.accept("hello")
     assert popup.evaluate("window.result") == "hello"