Fix so that Runtime.PyModuleType is retrieved via Python.dll (#904) #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a good thing to me |
|
Thank you very much for this precise analysis and the fix, greatly appreciated! :) |
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Currently the PyModuleType is deduced from the
__builtin__module. However, this fails when some third party package messes with this module (Nuitka). In this PR the PyModuleType is deduced directly from the Python shared library instead, which should be a safer approach to achieve the same.Does this close any currently open issues?
#904
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG