Remove delegate casting #936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the NET standard documentation for GetDelegateForFunctionPointer
f759889 to
7dc3aa1
Compare
|
@filmor I don't believe I can kick the build ... |
|
@jmlidbetter can you open a bug for the issue you are trying to fix with repro steps? |
|
@lostmsu You can repro the issue by compiling in dotnet core which I don't believe is officially supported so didnt think an issue is strictly necessary in this case. Check out pr 550 for more background / precedent on the changes as well as the other things mentioned above :) |
|
Looks good to me. |
lostmsu
approved these changes
Aug 20, 2019
filmor
approved these changes
Aug 26, 2019
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 18, 2020
…n the NET standard documentation for GetDelegateForFunctionPointer (pythonnet#936)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Fixes an issue where pythonnet attempts to cast one managed delegate to another. This is explicitly forbidden in the documentation: see here. In particular:
I have also removed the usage of the obselete function GetDelegateForFunctionPointer(IntPtr, Type) and replaced it with GetDelegateForFunctionPointer<IntPtr).
Does this close any currently open issues?
No
Any other comments?
It seems like this issue got partially fixed in PR #550 and was mentioned in issue #96. See also this related issue in dotnet core.
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG